keymanapp / keymanapp/keyman

refactor(web): Can we refactor to avoid this.firstCall?

Open
#5,367 0 comments 0 reactions 0 assignees View on GitHub
refactor web/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

Review comment from #5260

Can we refactor to avoid this variable? split this into two functions?

_Originally posted by @mcdurdin in https://github.com/keymanapp/keyman/pull/5260#discussion_r654157292_

kmwkeyboards.ts
```
if (this.firstCall) {
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.