keymanapp / keymanapp/keyman

chore(developer/compiler): additional buffer checks in GetXString

Open
#4,843 0 comments 0 reactions 0 assignees View on GitHub
bug developer/ developer/compilers/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

**Describe the bug**

`GetXString` in compiler.cpp has a number of places where it doesn't check buffers adequately. It needs to check the length of the output tstr buffer before incrementing mx. This was discovered out of the work done in #4831.

---

**Keyman Developer:**
- OS: Windows 10 20H2 x64
- Keyman Developer version: 14.0.270

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.