keymanapp / keymanapp/keyman

chore(windows): refactor C++ and Delphi shared units into static(?) libraries

Open
#4,597 0 comments 0 reactions 0 assignees View on GitHub
chore windows/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

```diff
- #include "stdafx.h"
+ #include "pch.h"
```

Because our global C++ classes are not yet in a shared library, we have to do dumb things like this where precompiled headers are inconsistent between projects. Yuck. Another possible groundwork project for 15.0?

_Originally posted by @mcdurdin in https://github.com/keymanapp/keyman/pull/4596#discussion_r587968291_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.