keymanapp / keymanapp/keyman

chore(web): SMP prediction unit tests

Open
#4,449 0 comments 0 reactions 0 assignees View on GitHub
chore web/ web/predictive-text/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

> Uh-oh. Just ran a test with an SMP model; SMP predictions seem to break on iOS with these changes. I'm fairly certain part of it is due to naive use of the `String.split` method b/c surrogates, but I'm not sure whether or not that's the only reason.
>
> _Originally posted by @jahorton in https://github.com/keymanapp/keyman/issues/4411#issuecomment-775664583_

While the PR-bound issue was resolved before that PR merged, we're kind of lucky that I managed to catch it; I only caught that one because I was testing a descendant branch for something else.

Unfortunately... the test model I used isn't currently published; it's based on something a user submitted as part of a bug report. We'll want something more freely-distributable for use in a unit test.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.