keymanapp / keymanapp/keyman

[iOS] Refactoring enhancement ideas

Open
#2,235 0 comments 0 reactions 0 assignees View on GitHub
feat ios/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

- [ ] Move view controller logic in Manager into a KMW view controller
- [ ] Remove setting the URL hash in KeymanWeb (since UIWebView is not longer used) and post an Object rather than String into WebKit
- [ ] Use promises/callbacks for HTTP rather than storing state in HTTPDownloadRequest and HTTPDownloader
- [ ] Remove code for background gradients in some views if unnecessary (eg. PopoverView, KeyPreviewView, SubKeysView)
- [ ] Refactor duplicated drawing code in the above views
- [ ] KeyboardMenuList list of keyboards should not contain the close button
- [ ] Reorganize groups in Xcode projects
- [x] Logging should be moved out of Manager. Also consider using a logging library and more log levels.
- [ ] Potentially use delegates instead of NotificationCenter

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.