keymanapp / keymanapp/keyman

bug(windows): automatic updates may not be able to find downloaded packages when admin user is not same as current user

Open
#16,360 0 comments 0 reactions 1 assignee Claimed by @rc-swag View on GitHub
bug windows/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

`Kmshell -ikp` is called, but does not pass any information about downloaded files. The admin user may not even have access to the files for the current user. So we need to consider, in this scenario, how to download and make the files accessible to the admin user.

https://github.com/keymanapp/keyman/blob/9c7b1a6ae6ddedbceff48ecb37a805e591abcaee/windows/src/desktop/kmshell/main/Keyman.System.UpdateStateMachine.pas#L1209-L1240

See also #16162, as this will also need to handle passing the baselayout setting to the elevated process.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.