keymanapp / keymanapp/keyman

maint(android): remove magic `KeymanBuildServer` environment variable from TC build configurations

Open Beginner friendly
#16,332 0 comments 0 reactions 0 assignees View on GitHub
android/ maint
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

In the past we used the `KeymanBuildServer` environment variable to limit builds of Keyman for Android to Keyman build agents. This variable is used nowhere in our code/build scripts, and its purpose is not documented nor why it has a particular GUID. So we should remove the variable since it only makes things more confusing when trying to figure out differences between agents.

We can use another Keyman specific variable as condition to limit builds to the Keyman build agents instead.

Contributor guide

Open the contributing guide

Research direction

Start by searching the TeamCity build configurations for the KeymanBuildServer environment variable and identify the existing Keyman-specific variable used to restrict Android builds. Done means the obsolete variable and its unexplained GUID are removed, the existing restriction remains effective, and the affected build configurations validate successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
android
Domain
build-system, ci-cd
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.