keymanapp / keymanapp/keyman

chore(core): use cleaner gtest patterns for error diagnostics

Open
#15,929 0 comments 0 reactions 1 assignee Claimed by @mcdurdin View on GitHub
chore core/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

Instead of having the `if (dst_nfd != expect_nfd)` block above that conditionally outputs the values, we could write a function that does that and then change the assert to:

```suggestion
ASSERT_EQ(dst_nfd, expect_nfd) << OutputValues(dst_nfd, expect_nfd);
```

_Originally posted by @ermshiperete in https://github.com/keymanapp/keyman/pull/15923#discussion_r3207657950_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.