keymanapp / keymanapp/keyman

maint(resources): `isTestBuild`/`IS_TEST_BUILD` flags are not clearly specified in build triggers

Open
#15,380 0 comments 0 reactions 1 assignee Claimed by @mcdurdin View on GitHub
maint resources/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

We have three different kinds of builds:

1. Test builds on PR branches
2. Test builds on master/beta/stable-x.y (no PRs associated)
3. Release builds on master/beta/stable-x.y branches

Each of these builds have slightly different characteristics. Currently, it isn't clear if `isTestBuild` covers both (1) and (2) above, or just (1) -- and the documentation is inconsistent. We should clarify this and make usage consistent, whether by eliminating the variable (and using e.g. [`KEYMAN_VERSION_TAG`](https://github.com/keymanapp/keyman/blob/bae371bb50f3c815d5f0ba7ad1868b0fa7191d60/resources/build/builder-basic.inc.sh#L10-L11))

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.