keymanapp / keymanapp/keyman

chore(mac): cleanup hints and warnings in builds

Open
#14,941 1 comment 0 reactions 1 assignee Assigned to @SabineSIL View on GitHub
chore mac/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

```
/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/KMEngineTests.m:299:13: warning: 9 enumeration values not handled in switch: 'NSEventModifierFlagCapsLock', 'NSEventModifierFlagShift', 'NSEventModifierFlagControl'... [-Wswitch]
299 | switch (modifiers[i]) {
| ^~~~~~~~~~~~
/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/KMEngineTests.m:299:13: note: add missing switch cases
299 | switch (modifiers[i]) {
| ^
/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/KMEngineTests.m:369:13: warning: 9 enumeration values not handled in switch: 'NSEventModifierFlagCapsLock', 'NSEventModifierFlagShift', 'NSEventModifierFlagControl'... [-Wswitch]
369 | switch (modifiers[i]) {
| ^~~~~~~~~~~~
/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/KMEngineTests.m:369:13: note: add missing switch cases
369 | switch (modifiers[i]) {
| ^

/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/CoreWrapperTests.m:30:13: warning: unused variable 'khmerKeyboardPath' [-Wunused-variable]
30 | NSString *khmerKeyboardPath = [[[NSBundle mainBundle] resourcePath] stringByAppendingPathComponent:@"khmer_angkor.kmx"];
| ^~~~~~~~~~~~~~~~~

/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/CoreHelperTests.m:142:17: warning: unused variable 'helper' [-Wunused-variable]
142 | CoreHelper *helper = [[CoreHelper alloc] init];
| ^~~~~~

/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4Mac.xcodeproj: warning: User-supplied CFBundleIdentifier value 'org.sil.KeymanEngine4MacTests' in the Info.plist must be the same as the PRODUCT_BUNDLE_IDENTIFIER build setting value 'Tavultesoft.KeymanEngine4MacTests'. (in target 'KeymanEngine4MacTests' from project 'KeymanEngine4Mac')
/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/KMEngineTests.m:299:13: warning: 9 enumeration values not handled in switch: 'NSEventModifierFlagCapsLock', 'NSEventModifierFlagShift', 'NSEventModifierFlagControl'... [-Wswitch]
299 | switch (modifiers[i]) {
| ^~~~~~~~~~~~
/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/KMEngineTests.m:299:13: note: add missing switch cases
299 | switch (modifiers[i]) {
| ^
/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/KMEngineTests.m:369:13: warning: 9 enumeration values not handled in switch: 'NSEventModifierFlagCapsLock', 'NSEventModifierFlagShift', 'NSEventModifierFlagControl'... [-Wswitch]
369 | switch (modifiers[i]) {
| ^~~~~~~~~~~~
/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/KMEngineTests.m:369:13: note: add missing switch cases
369 | switch (modifiers[i]) {
| ^

/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/CoreWrapperTests.m:30:13: warning: unused variable 'khmerKeyboardPath' [-Wunused-variable]
30 | NSString *khmerKeyboardPath = [[[NSBundle mainBundle] resourcePath] stringByAppendingPathComponent:@"khmer_angkor.kmx"];
| ^~~~~~~~~~~~~~~~~

/Users/marc_durdin/buildAgent/work/99b311828f4ee7c/keyman/mac/KeymanEngine4Mac/KeymanEngine4MacTests/CoreHelperTests.m:142:17: warning: unused variable 'helper' [-Wunused-variable]
142 | CoreHelper *helper = [[CoreHelper alloc] init];
| ^~~~~~
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.