maint(resources): rename one or both of `builder_if_release_build_level` and `builder_is_ci_build_level_release`
- Dominant language
- Pascal
- Stars
- 534
- Forks
- 143
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 113
Description
> Yeah, I got this wrong here (conflating `builder_if_release_build_level` and `builder_is_ci_build_level_release`). `install` should only be run on local anyway, so we should die if it happens in CI. Then we don't need to change the previous test.
_Originally posted by @mcdurdin in https://github.com/keymanapp/keyman/pull/14467#discussion_r2268488744_
----
These are not named terribly well. While I am happy with the way the build bot functions, the build level terminology could use another round of polish -- there's too much confusion between build, test, release terms:
* We can build a release with release buildLevel on master,beta,stable-x.y branches
* We can build a test version of a PR with artifacts with release buildLevel
* We can run unit tests on a PR but not provide artifacts with build buildLevel
Ugh. Perhaps `build-bot: build` should have been `build-bot: test`? Please chime in with your thoughts.
Then, `builder_if_release_build_level` could be `builder_if_not_ci_or_ci_build_level_release` (yikes!) to better express what it is doing. Clearly needs some polish.
Contributor guide
Assessment
This issue has not been assessed yet.