keymanapp / keymanapp/keyman

chore(common): move typescript kmx/kmx-plus from common/web to developer/common/web

Open
#14,251 0 comments 1 reaction 0 assignees View on GitHub
chore common/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

> I am slightly puzzled as to why we have stuff relating to XML in common/web/types rather than in developer/. kmx-plus is not used in any of our JS code, just consumed by core, so we shouldn't have a need for any of that in common/ I would have thought. I may be forgetting something.

Not xml per se. But the kmx-plus level APIs (the in memory stuff) for in this case element string construction are in common/web/types and so to be able to pass compileContext to them i hoisted the compileContext type to common/web/types

I'd be ok with moving common/web/types/src/kmx over to developer/.. but that's not where it is now and need to make sure all of the dependentants can call into developer/

_Originally posted by @srl295 in https://github.com/keymanapp/keyman/issues/14218#issuecomment-3010043921_

We should not need to load .kmx (or .kmx plus) in engine code; it should be possible to refactor most of this code into developer. One possible exception: loading metadata from .kmx files during keyboard installation or the like. (Ideally, Core would provide the metadata for a given blob on request)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.