keymanapp / keymanapp/keyman

chore(android): preference key names should not be resource strings

Open
#13,633 1 comment 0 reactions 1 assignee Claimed by @jahorton View on GitHub
android/ chore
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

> afaict, the preference key name has always been a resource string back in Keyman for Android 2.8

Can we do a chore to pull it into a constant? It's silly to be grabbing resources in order to just get a fixed string name. It's not translatable, and it should never change.

_Originally posted by @mcdurdin in https://github.com/keymanapp/keyman/issues/13578#issuecomment-2764886503_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.