keymanapp / keymanapp/keyman

chore(linux): why do we pass `'None'` as string in `OnboardGtk.py`

Open
#12,330 1 comment 0 reactions 1 assignee Claimed by @ermshiperete View on GitHub
chore linux/ linux/onboard/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

[`cb_keyman_changed`](https://github.com/keymanapp/onboard-keyman/blob/998c7c68eb2635d88d39820a9b10a2f9bb07ea47/Onboard/OnboardGtk.py#L571) in `OnboardGtk.py` gets a font name for key labels passed in. If none is set we get the string value `'None'`. This smells like it should be the `None` value instead.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.