bug(developer): if a package has no `<DisplayFont>` but does have `<WebDisplayFont>` then kmc-keyboard-info will error if the font is not in the package
- Dominant language
- Pascal
- Stars
- 534
- Forks
- 143
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 113
Description
I need to dig deeper on this. The intent is that the web fonts do not need to be in the package:
https://github.com/keymanapp/keyman/blob/fae6277b20dda9d7bbdb8519507a73d5ae30002a/common/schemas/kps/README.md#L12-L13
(I see a typo in that file...)
However, I think that the .keyboard_info generator will fail at present in one specific scenario:
1. There is a `` or (``) element
2. It lists at least one .ttf, .otf, or .woff
3. There is no `` (or `` for `` above) entry which lists a .ttf, .otf, or .woff.
4. The referenced .ttf, .otf, or .woff from point 2 is not in the package.
https://github.com/keymanapp/keyman/blob/a001bbd1050dacf25150e5a4d1255c9e244aac98/developer/src/kmc-keyboard-info/src/keyboard-info-compiler.ts#L593-L597
_Originally posted by @mcdurdin in https://github.com/keymanapp/keyboards/pull/2800#discussion_r1626867514_
Contributor guide
Assessment
This issue has not been assessed yet.