keycloak / keycloak/keycloak-nodejs-connect
Middleware does not allow for async request
- Dominant language
- JavaScript
- Stars
- 740
- Forks
- 442
- PR merge metrics
- No merged PRs in 30d
Description
### Description
Reviving the following old PR as I'm hitting the same issue:
https://github.com/keycloak/keycloak-nodejs-connect/pull/97
https://issues.redhat.com/browse/KEYCLOAK-5771?workflowName=GIT+Pull+Request+workflow+&stepId=4
I need to use an async GuardFn for my application.
New PR is here:
https://github.com/keycloak/keycloak-nodejs-connect/pull/355
### Discussion
_No response_
### Motivation
_No response_
### Details
_No response_
Contributor guide
Research direction
Start by reviewing the proposed changes in PR 355 and the earlier PR 97, then trace the middleware entry point and GuardFn usage they address. Done means the middleware accepts and correctly handles an async GuardFn for the reported application use case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100