keybase / keybase/keybase-issues

URL verify default to https

Open
#648 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
899
Forks
40
PR merge metrics
No merged PRs in 30d

Description

The URL verifier defaults to https if a domain can be reached at https. This isn't always correct, especially with virtual hosts.

Example : I wanted to verify http://www.palsenberg.com, but the IP it resolved to also has some https hosts. https on www.palsenberg.com wasn't configured.
I wasn't able to complete the verification until the www.palsenberg.com was actually reachable over https.

Contributor guide

No contributing guide indexed for this repository

Research direction

No file or test is identified. Start by locating the URL verifier and reviewing how it selects HTTPS based on the resolved IP rather than the requested hostname. Reproduce the virtual-host case described in the issue, and consider the work complete when an HTTP URL is not forced to HTTPS solely because another host at the same IP supports it.

Written by the indexing model from the issue text.

Assessment

Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.