keybase / keybase/keybase-issues

Updating public key from website is broken

Open
#4,060 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
899
Forks
40
PR merge metrics
No merged PRs in 30d

Description

### Steps to reproduce

1. Login on the website and load your profile (e.g. https://keybase.io/diafygi)
2. Next to your public key, click the "edit" link.
3. Two options will appear: "Update my key (I edited it elsewhere)" and "Host an encrypted copy of my private key".
4. Clicking "Update my key..." doesn't do anything. A console error says, `Uncaught TypeError: window.SigModalUis[link_data.sig_gen] is not a constructor`

### Fix

It appears this link doesn't have the appropriate data attribute that triggers the public key update flow.

To manually fix, if you inspect the link element and manually add the data field, the link works again:

Original:
```
Update my key (I edited it elsewhere)
```

Change to:
```
Update my key (I edited it elsewhere)
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the website code for the link-add-signed-statement element and the data-ss_sig_gen attribute, then reproduce the profile key-edit flow in the browser. Done means the update link includes the PGPUpdate value and clicking it opens the public-key update flow without the reported constructor error.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.