keybase / keybase/keybase-issues

Feature Request: Include search term in giphy message

Open
#3,621 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
899
Forks
40
PR merge metrics
No merged PRs in 30d

Description

The giphy integration in keybase is pretty good. The only thing I think that would improve it is to include the term that was used for the search. This is useful for context when sending gifs (especially if one chooses to send randomly).

For example, if one types /giphy hello, the resulting message would include the hyperlinked hello with an href to the giphy URL.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the giphy integration and the handler for the /giphy command. Check how the resulting message is assembled, then verify that a search such as /giphy hello includes a hyperlinked hello pointing to the Giphy URL.

Written by the indexing model from the issue text.

Assessment

Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.