keybase / keybase/keybase-issues

Key options for failing proofs prompt aren't conventional.

Open
#2,647 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
899
Forks
40
PR merge metrics
No merged PRs in 30d

Description

```
Some proofs are failing. [A]ccept these changes or [C]ancel?:
Some proofs are failing. [A]ccept these changes or [C]ancel? (A, C):
```

The unix convention is that the casing of the input to a prompt is ignored; and further that the default value (the one that would be used if a user just presses `Enter`) is the only one listed in uppercase.

It appears that this message does not have a default so I would expect the prompts to be:

```
Some proofs are failing. [a]ccept these changes or [c]ancel?:
Some proofs are failing. [a]ccept these changes or [c]ancel? [a/c]:
```

As an enhancement, perhaps make one of the options a default?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the client code that formats the failing-proofs prompt and check how its accepted options and default are represented. Done means the prompt follows the stated Unix casing convention and either documents or implements a clear default option, with coverage for the displayed wording.

Written by the indexing model from the issue text.

Assessment

Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.