keybase / keybase/keybase-issues

Close popovers with Escape and clicking outside them

Open
#2,198 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
899
Forks
40
PR merge metrics
No merged PRs in 30d

Description

Unless the popover requires action (as when uploading a PGP key or adding a proof) they should close when I click outside them or press `Escape`. Much more convenient than using the `x`.

When inspecting someone's PGP key is one example.

Contributor guide

No contributing guide indexed for this repository

Research direction

No files or tests are named. Start by locating the popover implementation and the flow for inspecting someone's PGP key; check which popovers require an action before dismissal. Done means non-action popovers close on Escape or an outside click while action-required popovers remain open.

Written by the indexing model from the issue text.

Assessment

Domain
frontend, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.