keybase / keybase/keybase-issues

Possible error in user lookup json

Open
#1,527 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
899
Forks
40
PR merge metrics
No merged PRs in 30d

Description

Hello Keybase,

I'm impressed with what you build, but I think your json isn't entiery correct. When I do a lookup of a user, I get the following json:

"sibkeys": {
                "01012bb08756ce435971935a34f9ef90b7165d5a026d3e66cd702a0d4ba56c26c99e0a": {
                    "kid": "01012bb08756ce435971935a34f9ef90b7165d5a026d3e66cd702a0d4ba56c26c99e0a",
                    "key_type": 1,
                    "bundle": "-----BEGIN PGP PUBLIC KEY BLOCK----------END PGP PUBLIC KEY BLOCK-----",
                    "mtime": 1428808360,
                    "ctime": 1428808360,
                    "ukbid": "069c51e4eb5c0676267180d43dfd0611",
                    "key_fingerprint": "02a0ef0a16b01757028c96704f617db20816088c",
                    "key_bits": 2048,
                    "key_algo": 1,
                    "signing_kid": null,
                    "key_level": 0,
                    "etime": null,
                    "eldest_kid": null,
                    "status": 0,
                    "self_signed": true
                }

What I think is wrong here, is the second line. It's just an kid, but without context. I think you need to structure the sibkeys, subkeys and family keys like the primary key:

"primary": {
                "kid": "01012bb08756ce435971935a34f9ef90b7165d5a026d3e66cd702a0d4ba56c26c99e0a",
                "key_type": 1,
                "bundle": "-----BEGIN PGP PUBLIC KEY BLOCK----------END PGP PUBLIC KEY BLOCK-----",
                "mtime": 1428808360,
                "ctime": 1428808360,
                "ukbid": "069c51e4eb5c0676267180d43dfd0611",
                "key_fingerprint": "02a0ef0a16b01757028c96704f617db20816088c",
                "key_bits": 2048,
                "key_algo": 1,
                "signing_kid": null,
                "key_level": 0,
                "etime": null,
                "eldest_kid": null,
                "status": 0,
                "self_signed": true
            }

Possibly making it an array if you need to send more, but you get the idea. :)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the user lookup JSON response, focusing on the sibkeys, subkeys, and family keys representations. Compare them with the primary key object and determine how to provide equivalent context for each key. Done means the lookup response consistently represents these key groups as requested.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.