keybase / keybase/keybase-issues

HTML-encoded links in email footer

Open
#1,326 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
899
Forks
40
PR merge metrics
No merged PRs in 30d

Description

I just received a "someone is tracking you" email and was viewing it in plaintext using mutt. The footer reads like this:

-----------
Unsubscribe:    https://keybase.io/_/user/account?unsub=1&amp;which=follow&amp;a=<some token>#link-tab-subscriptions
Mail settings:  https://keybase.io/_/user/account?a=<some token>#link-tab-subscriptions

The unsubscribe link is needlessly converted to &amp;, even though the mail is plaintext.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the code that generates the plaintext email footer and reproduce the reported output in mutt or an equivalent plaintext view. Trace why the unsubscribe URL's ampersands and angle brackets are HTML-encoded, then verify that plaintext footers contain usable URLs without HTML entities.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.