keybase / keybase/keybase-issues

API: I can add a key with a userid@keybase.io (packet) that doesn't match my username

Open
#1,237 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
899
Forks
40
PR merge metrics
No merged PRs in 30d

Description

This is probably ok since its ignored if not matching, but might be a good idea to add a check to make sure and userid@keybase.io user id packet (if included) in key also matches the keybase username associated with an account (if only as a sanity check).

(Yeah, I am testing wierd scenarios.)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the API path that accepts keys containing a userid@keybase.io packet and identify where the packet is compared with the account username. Confirm the intended behavior for mismatches, then add coverage showing that an inconsistent packet is rejected or ignored as decided. Done means the sanity check is enforced without breaking valid keys.

Written by the indexing model from the issue text.

Assessment

Domain
api, authentication, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.