keybase / keybase/keybase-issues
Web decrypt/verify silently fails on bad armor
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 899
- Forks
- 40
- PR merge metrics
- No merged PRs in 30d
Description
When passing messages back and forth via Facebook, the dumb FB engine formats out the blank line between the armor and the encrypted data. Thus a gpg -d returns a "invalid armor" warning.
This is easy enough to fix by hand, but pasting the text straight into the keybase.io decrypt or verify page appears to just silently fail; clicking the button does nothing. This is not very user friendly and gives no indication of what the problem is (even echoing back the error from gpg would be better than silence).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the keybase.io decrypt and verify pages and reproduce the behavior with armored text missing the blank line. Check how the page handles the gpg invalid-armor failure; done means the user receives a visible error instead of the button appearing to do nothing.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100