keybase / keybase/client

Client injects "@keybase" when a string mentions @you

Open
#9,369 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Version:

$ keybase version
Client:  1.0.35-20171103110013+8913b0236
Service: 1.0.35-20171103110013+8913b0236

Before:
image

After:
image

Note the "@shazow@keybase" instead of "@shazow". Of course, this breaks the link.

Another easy way to reproduce:
image

image

Seems to only happen when it's your own handle being mentioned.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by mentioning @you in a string and compare the displayed handle and link with the expected @shazow result. Trace the client entry point responsible for rendering mentions; done means mentioning your own handle no longer appends @keybase and the resulting link works.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.