keybase / keybase/client

Inconsistent behaviour when quitting the client

Open
#9,008 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Using the latest OSX, if I right click on the client icon on the dock and press click, the application logs off and shuts down. Doing ps -ef | grep keybase on Terminal sometimes shows no processes with the Keybase name or just /Library/PrivilegedHelperTools/keybase.Helper.

But if I open the application, hover the mouse on the menu bar on top of the screen, click on the application name (Keybase) and then "Quit", I don't see a busy spinner on the application window and a number of Keybase processes are left running which makes me believe that this merely hides the window.

The Quit command should terminate the application according to OSX development guidelines (admittedly I last checked this in 2012). Is the behaviour of the menu icon command correct?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the two quit paths described: the Dock icon command and the menu bar Keybase > Quit command, then inspect the remaining processes with ps -ef | grep keybase. Done means the menu bar Quit behavior is clarified and, if it is incorrect, the command terminates the client processes rather than merely hiding the window.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos
Domain
desktop, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.