renaming sub-team leads to UI confusion and inability to leave channel
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 9.2k
- Forks
- 1.3k
- Avg merge
- 12h 58m
- Merged PRs (30d)
- 56
Description
running keybase 1.0.31-20170917003451+ed4bf6a71 on arch linux
i created a team:
[~] ▶ keybase team create wkray_test_team1
Success!
i then create a subteam:
[~] ▶ keybase team create wkray_test_team1.subteam1
Success!
NOTE: you can administer wkray_test_team1.subteam1, but you won't see its files or chats unless you add yourself explicitly with `keybase team add-member`.
then i add myself to the team:
[~] ▶ keybase team add-member wkray_test_team1.subteam1 -u williamkray -r admin
Success! A keybase chat message has been sent to williamkray.
at this point the UI is now showing that i'm a member of this subteam. however if i rename the sub-team:
[~] ▶ keybase team rename wkray_test_team1.subteam1 wkray_test_team1.newteamname
the UI still shows the old name, even after restarting the application fully with run_keybase
if i create a new channel in the subteam after renaming it, both subteams show up in the UI as separate teams in my sidebar, each with its own set of channels.
[~] ▶ keybase chat create-channel wkray_test_team1.newteamname newchannel
Success!
screenshot: https://imgur.com/Xw1Fcis
if i attempt to leave the team from the CLI with either the new name or the old name, i receive an error:
[~] ▶ keybase chat leave-channel wkray_test_team1.newteamname general
▶ ERROR server conversation TLF name mismatch: wkray_test_team1.subteam1, expected wkray_test_team1.newteamname
[~] ▶ keybase chat leave-channel wkray_test_team1.subteam1 general
▶ ERROR You are not a member of this team (code 2623)
with two channels now, i cannot simply rename the team and leave the general channel:
[~] ▶ keybase team rename wkray_test_team1.newteamname wkray_test_team1.subteam1
[~] ▶ keybase chat leave-channel wkray_test_team1.subteam1 general
▶ ERROR server conversation TLF name mismatch: wkray_test_team1.newteamname, expected wkray_test_team1.subteam1
and even after renaming and attempting to leave the secondary channel, i have clearly broken something:
[~] ▶ keybase team rename wkray_test_team1.subteam1 wkray_test_team1.newteamname
[~] ▶ keybase chat leave-channel wkray_test_team1.newteamname newchannel
▶ ERROR server conversation TLF name mismatch: wkray_test_team1.subteam1, expected wkray_test_team1.newteamname
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the sequence using the keybase team create, team rename, team add-member, chat create-channel, and chat leave-channel commands, then inspect the team sidebar and channel state. Done means a renamed subteam appears only once in the UI and leaving its channels no longer produces a TLF name mismatch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, linux, react
- Domain
- backend, cli, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100