keybase / keybase/client

sources.list.d/keybase.list is created without HTTPS repo url

Open
#8,428 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

The cronjob that maintains the keybase.list file has the HTTPS repo url in it, but does not use it:

https://github.com/keybase/client/blob/master/packaging/linux/deb/cron.template#L221

IMHO, it would be better to remove all references to REPOCONFIG from cron.template, and only ever use SSLREPOCONFIG. Then after an upgrade, update_bad_sources will detect that the machine is still using the non-HTTPS repo and fix it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at packaging/linux/deb/cron.template around line 221 and inspect how REPOCONFIG and SSLREPOCONFIG are used by the cronjob. Check the update_bad_sources path, then confirm that an upgrade detects and corrects a non-HTTPS repository without retaining unnecessary REPOCONFIG references.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.