keybase / keybase/client

Paper key device created even when "Done" button is not clicked

Open
#8,413 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Platform: Keybase on Windows

When generating a paper key on Keybase for Windows, I assumed that the paper key just generated would not be saved until I clicked the "Yes, I wrote it down" checkbox and then clicked the "Done" button. Unfortunately, just the act of clicking "Add new" -> "New paper key" will always create a paper key device regardless of what happens in the subsequent dialog.

It is not possible to click the "Back" link to abort the creation of the paper key. This behavior does not match the behavior of "Add new" -> "New new phone" and "Add new" -> "New new computer". In these latter cases, clicking the "Back" button does abort creation of the device.

Result of this unexpected behavior is paper key devices that are useless because the user thought they were aborting the creation of a paper key device and did not write down the passphrase.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Windows flow for Add new → New paper key and compare its Back behavior with New phone and New computer. Confirm that leaving the paper-key dialog without checking the confirmation box or clicking Done does not create a device, while completing the flow still does.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.