keybase / keybase/client

There should be an option to turn off the /keybase mount point

Open
#8,095 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

There should be an "approval" before files are dropped on your system. You couple keybase with the recently released git vulnerability and then Keybase could enable a worm to spread through people's systems using keybase.

https://marc.info/?l=git&m=150238802328673&w=2

This could be prevented by requiring "approvals" before files are placed on a system through KBFS. Hopefully I am missing something, but I think that this is a potential issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by reviewing how KBFS exposes the /keybase mount point and the linked Git vulnerability discussion, then determine whether the requested control is a mount-disable option, file approval flow, or both. Done should be a documented, tested way to prevent unapproved files from being placed through KBFS.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
operating-systems, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.