keybase / keybase/client

Android device name validation failure nerfs submit button

Open
#7,035 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Howdy folks,

When attempting to sign in on my phone (nexus 6p), I tried to name the device "6p" - this failed a validation check, presumably server-side. But from there it took me to the "Enter Passphrase" screen, with a red error message saying "Invalid device name". Fair enough.

Unfortunately, the button was greyed out with the spinning icon, so I couldn't proceed that way. I clicked through the dropdown menu "Something else" -> "Another user" (or similar - foolishly I did not write it down or take a screenshot), but when it returned me to the "Enter your username" screen, the button was still greyed out and spinning.

I had to kill the app and restart it to reset it before being able to successfully continue and name my phone something valid.

Android app version: 1.0.22-20170510190320+2a0be5e72

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The report concerns the Android sign-in flow, especially the Enter Passphrase and Enter your username screens, but names no files or tests. Start by reproducing the invalid device-name path with the reported app version, then verify that the button recovers after the validation error and after choosing another-user navigation, while valid naming still permits sign-in.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, react-native
Domain
authentication, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.