keybase / keybase/client

Chat: Links with Chinese don't work

Open
#6,898 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Keybase GUI Version: 1.0.22-20170502110012+a3c4856

macOS: 10.12.4

  1. Paste a URLs with Chinese characters into a chat
  2. Link making algorithm ignores Chinese portion of the URL.

Example:

Pasting the link https://www.thestandnews.com/politics/再有政府人員到hidden-agenda-放蛇-警車-大批持盾警員到場欲拘捕-ha-負責人/ into a chat results in a link to https://www.thestandnews.com/politics/

screen shot 2017-05-08 at 11 31 58 am

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report in the Keybase GUI chat on macOS by pasting the provided URL containing Chinese characters. Trace the link-making behavior that turns it into a link ending at /politics/, and consider the issue done when the complete URL is recognized as one chat link.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.