keybase / keybase/client

No https in keybase.repo baseurl

Open
#6,798 8 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

It would be much preferred for security reasons if the keybase.repo file by default used https for the baseurl. As it is now, it becomes:

baseurl=http://prerelease.keybase.io/rpm/x86_64

This means that updates to the software is downloaded over http.

I can see there is some logic (repo_ssl_url) in client/packaging/linux/rpm/package_binaries.sh, but I haven't looked into the reason why https is not default.

There is a variable SSLREPOCONFIG in /etc/cron.daily/keybase, but it is not used, and contains also http. To make it default to https, I had to edit /etc/cron.daily/keybase and set REPOCONFIG="https

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with client/packaging/linux/rpm/package_binaries.sh and /etc/cron.daily/keybase, focusing on repo_ssl_url, SSLREPOCONFIG, and REPOCONFIG. Trace how keybase.repo is generated and verify that the default repository URL uses HTTPS for updates; confirm the relevant Linux packaging or update checks afterward.

Written by the indexing model from the issue text.

Assessment

Tech stack
linux, shell
Domain
devops, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.