keybase / keybase/client

Non-standard installation and data location should not be used

Open
#6,037 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

I noticed that the Keybase client on Windows gets installed in %APPDATA%\Local\keybase. In addition, it stores all data for the user there. There are a few serious issues with this:

  • Normal installation location for programs is "Program Files". That is the convention for installing software on a Windows O.S. and that is where the user expects the program files to go.
  • This location also implies that a separate copy must be installed for each user account. That's bad.
  • %APPDATA%\Local is an unprotected location, meaning any malware will have full access to the application's files and can modify the keybase client in any way it wishes!
  • On a roaming profile, e.g. when using a DC, the user's keybase data will not be transferred and will not roam with the user. This is why personal user data for applications (like documents, configuration, keys, etc.) should be stored in Roaming, not Local.
  • Contrary, the normal user data location, %APPDATA%\Roaming is apparently used for cached (browser?) files - this is backwards, and that kind of data should be in Local as there's no point in having that data in a roaming profile.
  • Storing the application and user data in Local also has the risk of this data being lost, depending on the policies applied on the network (Local user data for a roaming profile may be deleted at will, it should not be considered critical)

Please consider setting the Windows client up with installation and data locations that are there by design for very good reasons.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue concerns the Windows client's installation and user-data locations, but names no files, tests, or entry points. Start by locating the Windows packaging and path configuration, then verify that application files, personal data, and cache data use the requested Windows locations and that existing installation and roaming behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
desktop, operating-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.