keybase / keybase/client

adding new device: <return> in code-entry field doesn't submit code

Open
#5,803 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Just a small UI nit: I added a new device today, and dutifully typed the code from the new device into the text field on the old device. Then I hit Return, but instead of the old device accepting the code (as I would have expected), it apparently inserted a literal CR/LF into the text field. I had to delete that and then hit the submit button directly. Since codes don't have newlines, I'd expect Return to perform the submit too.

Incidentally, it wasn't immediately obvious that I needed to get a code from the second machine. The text says "Type in text code. In the Keybase app on your computer, go to Devices > Add a new device". On the other computer, I started Keybase (for the first time), type in my username, then saw something about having another device, and found the code to type in.

I was uncertain about the flow, maybe because of the fake code grayed-out in the code-entry field on the old computer. Maybe the text could say "Type in a text code from the new device. To get it, start the Keybase app on the new computer, go to Devices > Add a new device".

(also, there's something funny with the flow, I wasn't even able to get to the "Add a new device" menu on the new computer, since I was still in the new-install sign-into-an-account flow).

I think something else is also wonky, because the new computer is recognized from the new computer and from the website (https://keybase.io/warner/devices), but not from the old computer (where I typed in the code). Restarting the Keybase app on the old machine didn't seem to help.

thanks!
-Brian

Keybase GUI Version: 1.0.18-20170209165653+17b641d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is identified. Start by locating the device-add code-entry UI and its submit handling; done means Return submits the code, while the additional onboarding and device-recognition reports are clarified or split.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.