keybase / keybase/client

Windows Keybase updater process timeout; Terminate not supported on Windows; PendingFileRenameOperations not found

Open
#5,240 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

my log id: fef2d1009423d3e42f03051c

Running upd.exe check results in

  1. the updater not being able to determine that the version installed is the most current version available
  2. download and installation of this version again

The version check appears to timeout. This is followed by an attempt to terminate a process, which fails, followed by a kill, which succeeds. (The fact that the messages are WARN, not ERR, and the message content, suggest this might be expected behavior on Windows.)

C:\Users\clark.e\AppData\Local\Keybase>upd.exe check
2017/01/01 04:01:54 DEBG Using default path to keybase: C:\Users\clark.e\AppData\Local\Keybase\keybase
2017/01/01 04:01:54 DEBG Execute: C:\Users\clark.e\AppData\Local\Keybase\keybase [version -S]
2017/01/01 04:01:59 WARN Process timed out
2017/01/01 04:01:59 WARN Command timed out, terminating (will wait 1s before killing)
2017/01/01 04:01:59 WARN Error sending terminate: not supported by windows
2017/01/01 04:02:00 WARN Command failed to terminate, killing
2017/01/01 04:02:00 WARN Killed process
2017/01/01 04:02:00 WARN Couldn't get keybase version: Timed out ([Stdout]
[Stdrr] )
2017/01/01 04:02:00 DEBG Execute: cmd [/c ver]
2017/01/01 04:02:00 DEBG Executed cmd [/c ver]
2017/01/01 04:02:00 INFO Checking for update, current version is
2017/01/01 04:02:00 INFO Using updater source: Keybase.io

An error occurred with PendingFileRenameOperations

2017/01/01 04:02:01 INFO Got update with version: 1.0.18-20161219123615+7868d49
2017/01/01 04:02:01 ERR  Error getting PendingFileRenameOperations: The system cannot find the file specified.
2017/01/01 04:02:01 ERR  Error getting PendingFileRenameOperations: The system cannot find the file specified.

The download and application of the "update" proceeds successfully.

A point of clarification: the GUI has NOT indicated an update was necessary. I was merely poking around with the command line client after a recent installation.

Thanks for all the hard work!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing upd.exe check on Windows and trace the keybase version -S timeout, process termination fallback, and PendingFileRenameOperations lookup. Done means the installed version is detected correctly, an unnecessary update is not downloaded, and the reported Windows errors no longer occur.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.