keybase / keybase/client

quit function is not working as expected

Open
#4,715 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Machine: Windows 7 Professional

When using File/Quit or Ctrl+Q of the windows client then the application is only minimized to the tray.
When using Dropdown Menu of the tray window and quit the application from there it is closed.

Quit of the client window should be renamed into minimize to tray or something.
A real quit command should be put into the client window to really quit the whole application from there.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the Windows client handlers for File/Quit and Ctrl+Q, then compare them with the tray menu's quit behavior. Done means the client window offers a real quit command that closes the application, while any minimize-to-tray action is named accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, go
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.