keybase / keybase/client

GUI message doesn't match the action that opened it

Open
#3,134 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

When I track a user from the CLI, the GUI pops up a window with info about the user; this is both unexpected and nice, even with the delay in the window appearing.

What is unexpected and not so nice is when I go to close the window and I get what appears to be a warning message with text doesn't match the action I was taking, e.g. tracking a user. Instead it displays "You will see this window every time you access this folder." even though I wasn't in a folder, or making any attempt to work with KBFS at that moment.

Can this be updated to not look like I've done something wrong, and to have the text match what action I was taking that prompted the GUI to open in the first place?
keybase-message

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with shared/tracker/header.render.desktop.js, especially the message linked in the issue, and trace how the GUI window is opened and closed after tracking a user from the CLI. Done means the displayed message describes the action that opened the window rather than implying KBFS folder access.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.