keybase / keybase/client

Muted channel notifications still appear in desktop client menu notification preview

Open
#23,495 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Muted channels should probably not display notifications here. Muted high volume channels will dominate the preview space, making it less useful.

Screen Shot 2020-04-04 at 08 28 45

There are lots of interesting, high-volume channels on keybase, and not allowing notifications to be suppressed for these channels has the unfortunate effect of discouraging joining them.

Contributor guide

No contributing guide indexed for this repository

Research direction

No file, test, or entry point is named. Start by reproducing the desktop client menu notification preview with a muted high-volume channel, then trace the preview's notification filtering. Done means muted-channel notifications no longer occupy the preview while unmuted notifications remain visible.

Written by the indexing model from the issue text.

Assessment

Tech stack
react
Domain
desktop, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.