keybase / keybase/client

iPad app should support portrait orientation, not just landscape

Open
#23,007 1 comment 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

I was very excited to see that the latest Keybase update for iOS now includes iPad support (#8909)! 🎉 Unfortunately it only works in landscape orientation, which I almost never use. It’d be great to have it work in both orientations.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the iPad support introduced in issue #8909 and the iOS app's current orientation handling. Verify how the app restricts iPad to landscape, then enable portrait support and test both orientations on iPad; done means the app works in landscape and portrait.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, react-native
Domain
mobile-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.