keybase / keybase/client

Editing a message then choosing to edit a different message has unexpected behavior

Open
#22,945 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

In chat on desktop, if I go through message's menu (...) and click "Edit" to enter edit mode, the message's content appears as expected in the new message field, ready for editing. However, if I then go through another message's menu to edit that one, the text in the chat bar does not change to that other message's content to edit. If I then press enter to save my edits, it saves the contents of the new message field to the second message, even though I was editing the first message's content.

(Same problem when entering edit mode by pressing the up arrow instead of through the message menu)

**Expected behavior**: when editing a message and I choose to edit a different one before pressing the enter key or the "Cancel" button, my edits to the first message are saved/cancelled automatically (or there is a prompt, "Would you like to save your changes?"), and then the edit view now shows the second message's content in the new message field, now that I am editing the second message.

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue names no file, test, or entry point. Start by locating the desktop chat message-editing flow and its edit-state transition; done means switching messages no longer applies the first message's text to the second and follows a defined save, cancel, or prompt behavior.

Written by the indexing model from the issue text.

Assessment

Domain
desktop, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.