keybase / keybase/client

Upstream fix for camera permissions issue on Android 5.0

Open
#22,910 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Apologies if this isn't the preferred way to make a note of this, but I've spent the last day or so poking around have figured out what's going on with https://github.com/keybase/client/issues/7329. The problem is an issue with Expo's ImagePicker module trying to use `requestPermissions` even on older versions of Android that don't support runtime permissions (pre-6.0). They have committed a fix upstream (https://github.com/expo/expo/pull/6736), which is supposed to be available in Expo 37. Once that's out, this problem should be fixable by updated the expo image-picker package to the newer version.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by checking the Expo ImagePicker dependency declaration and the Android camera-permission path, then compare the available version with the upstream Expo fix and Expo 37. Done means the project uses the fixed ImagePicker package and the Android 5.0 camera-permission issue is covered by an appropriate verification or test.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, react-native
Domain
mobile-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.