Linux client can't open links on Fedora/GNOME
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 9.2k
- Forks
- 1.3k
- Avg merge
- 12h 58m
- Merged PRs (30d)
- 56
Description
The Linux client fails to open links on Fedora/GNOME:
The problem is this line forcing XDG_CURRENT_DESKTOP:
This line causes xdg-open to fail detecting the right way to open links for the desktop environment, instead falling through to open_generic which ultimately fails. It seems likely that forcing XDG_CURRENT_DESKTOP may cause other issues throughout the xdg suite as well.
It seems unlikely that forcing XDG_CURRENT_DESKTOP unconditionally is a good approach. If this workaround is still needed, then it should be conditionalized to the environment that needs it. Otherwise maybe we could just kill it?
See also https://github.com/keybase/client/pull/10903 and https://github.com/electron/electron/issues/10887
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packaging/linux/run_keybase around lines 115-118 and reproduce the xdg-open failure on Fedora/GNOME. Check whether the unconditional XDG_CURRENT_DESKTOP setting is still needed, then verify that links open through the appropriate desktop environment without causing the reported failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, linux
- Domain
- desktop, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100