keybase / keybase/client

Double Click Titlebar Area Does NOT Maximize Window

Open
#22,348 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Keybase GUI Version: 5.1.1-20191211223249+15bbb94c23

^^ explains it

fix 👇

<div className="hidden" style={height:"2em", width:"100%"} onDoubleClick={this.handlieDoubleClick}/>

handleDoubleClick = () => {
    ipc.send("evt-window-resize, () => { console.log("resized window to maxium")})
}

now just put a listener in your main process window class for the evt-window-resize and grap the dimension from the display object. use workArea attributes for width and height then call setSize() on the BrowserWindow class is that of the window. gl;hf

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Electron renderer's titlebar area and the main-process BrowserWindow entry point described in the issue. Trace the IPC event, display workArea dimensions, and setSize behavior; done means double-clicking the titlebar area maximizes the window.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, react
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.