keybase / keybase/client

[FEATURE] macOS: Avatar in Notifications

Open
#21,677 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

I'm porting my «halluzinelle» bot from Matrix to Keybase.

Chat notifications on macOS currently look something like this:

Screen Shot 2019-12-17 at 19 15 55

It would be great to show the avatar of the user sending the chat message instead of the keybase icon. However, this might be impossible due to restrictions by Apple.

Rambox (in this example using Riot/Matrix) and other applications use a different approach and include the avatar in the notification payload:

Screen Shot 2019-12-17 at 19 15 05

Another difference between the two notifications: Rambox displays the username and the team as title and leaves the notification text free for the message. Personally, I like this more than the way Keybase does things, specially for bots which communicate e.g. repo activity:

Screen Shot 2019-12-17 at 19 23 23 Screen Shot 2019-12-17 at 19 23 57

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue provides screenshots and two possible macOS notification presentation changes but names no files, tests, or entry points. First determine whether macOS permits the requested avatar in the notification payload and locate the relevant chat-notification implementation; done means showing the sender avatar and evaluating the proposed username/team title layout.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.