keybase / keybase/client

User experience when sending to Stellar wallet with autogenerated memo

Open
#21,251 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Hi, this is a follow up on #19388
It works great, resolves memo and doesn't let user override it.
Screen Shot 2019-11-26 at 10 12 18 AM

However when you opt-in for a path_payment, there is still an editable field for memo
Screen Shot 2019-11-26 at 10 12 11 AM

Thankfully, putting anything there leads to an error
Screen Shot 2019-11-26 at 10 12 59 AM

But I'm sure you can do better than scaring users away with error messages by not allowing to edit this field.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the Stellar wallet send flow with a path_payment selected and compare it with the ordinary send flow shown in the issue screenshots. Trace where the memo field is rendered and validated; done means the autogenerated memo cannot be edited in this flow and users are not led to the existing error.

Written by the indexing model from the issue text.

Assessment

Domain
frontend, payments
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.