keybase / keybase/client

Automatically sends repeated requests to webserver when a link is sent in chat

Open
#20,889 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

There's some very strange behaviour when sending links in chat in Windows 10.

When merely pasting a link into the chat box (Without sending), a GET request is sent to the URL, along with a GET request to /apple-touch-icon-icon.png.

When sending the link into the chat it results in the request being repeated indefinitely in precisely 5 second intervals. The requests continue to be sent even after the client is closed, both from the window "X", and from the system tray. Only by killing all keybase processes in Task Manager do the requests stop.

Here's some data I collected from a flask application I used to record the requests ("wahed" is just the name of the route I used for testing and is unrelated):
repeating requests
Request header followed by the request body (empty):

POST /wahed HTTP/1.1 200 -
Host: <removed>:1337
User-Agent: Mozilla/5.0 (compatible; Keybase; +https://keybase.io)
Accept: */*
Upgrade-Insecure-Requests: 1
Accept-Encoding: gzip
Connection: keep-alive

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are named. Start by reproducing the link-paste and link-send behavior in the Windows 10 desktop chat client, then trace the link-preview request handling and shutdown behavior. Done means requests are not repeated indefinitely and stop when the client closes.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.