keybase / keybase/client

Android : Giphy media stops music

Open
#20,663 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Gifs from giphy (inserted with /giphy command) are .mp4 videos, which when played back, stops any music played with a background player in Android. That means that if a gif has been sent, every member of the chat will have his music stopped when reading the chat.

Even if it's a correct behavior for normal .mp4 videos, i believe videos from giphy should not interrupt background sound playing.

Android version : 9
Music player : Poweramp Pro or "Music" app
Keybase version : 4.7.2
Untested on iOS, but it might have the same behavior.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the /giphy playback behavior on Android 9 with a background music player, then trace the Android media playback path used for Giphy's .mp4 content. Done means opening a Giphy GIF in chat no longer interrupts background music while normal .mp4 video behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, react-native
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.