keybase / keybase/client

BaseFee Value is Incorrect.

Open
#20,340 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

The code that determines the amount the "Available to send" displays for a Stellar wallet seems to be incorrect.

It's deducting 200 stroops. From what I can tell, Keybase gets this BaseFee value from the Stellar network directly. However the current ledger shows the fee as being 100 stroops.

Code in question: https://github.com/keybase/client/blob/9f48d6b9967c57f09342590f4d14476dd3739996/go/stellar/build.go#L1041-L1055

Ledger info: https://horizon.stellar.org/ledgers/26277134

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in go/stellar/build.go at lines 1041-1055 and compare its BaseFee handling with the Stellar ledger information for ledger 26277134. Trace how the value feeds the wallet's “Available to send” display, then verify the calculation against the network fee and add or update coverage for the corrected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
blockchain
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.